Sanitize Headers on Errors #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmyjames
commented
Jul 20, 2020
| !error.response || | ||
| !error.response.request || | ||
| (!error.response.request._data && !error.response.request._header) | ||
| ) { |
There was a problem hiding this comment.
I'm not a huge fan of this formatting, but the pre-commit hook did this, so 🤷
jimmyjames
requested review from
a team and
davidpatrick
and removed request for
a team
jimmyjames
added
medium
jimmyjames
changed the title
davidpatrick
approved these changes
Jul 21, 2020
prabhu
reviewed
Jul 31, 2020
| } | ||
|
|
||
| Object.keys(collection).forEach(function(key) { | ||
| if (key.toLowerCase().match('password|secret|authorization')) { |
There was a problem hiding this comment.
I'm not a big fan of such block list approach. This would miss keys such as token, bearer, auth, key and so on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sanitize the authorization header on errors, as we do with passwords and secrets.
Testing
Checklist